Upgrade go to 1.20.4 and fix go version detection to address test failures#1319
Merged
vihangm merged 3 commits intopixie-io:mainfrom May 10, 2023
Conversation
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
vihangm
force-pushed
the
ddelnano/upgrade-go-1-20-4-fix-http-tracing-issues
branch
2 times, most recently
from
97dc775 to
f975d83
Compare
ddelnano
force-pushed
the
ddelnano/upgrade-go-1-20-4-fix-http-tracing-issues
branch
2 times, most recently
from
239b00f to
f975d83
Compare
Member
Author
|
@pixie-io-buildbot test this please |
ddelnano
force-pushed
the
ddelnano/upgrade-go-1-20-4-fix-http-tracing-issues
branch
from
0aa6a5f to
81da53b
Compare
…Version.str ELF symbol if its available Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
force-pushed
the
ddelnano/upgrade-go-1-20-4-fix-http-tracing-issues
branch
from
81da53b to
d13d333
Compare
vihangm
approved these changes
May 10, 2023
Closed
etep
approved these changes
May 10, 2023
ddelnano
deleted the
ddelnano/upgrade-go-1-20-4-fix-http-tracing-issues
branch
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
…lures (pixie-io#1319) Summary: This upgrades our golang SDKs to the latest patch version to pull in bug fixes and security fixes. Our go tls tracing tests failed with this minor version upgrade. These failures are due to our go version detection failing, which prevents stirling from adding uprobes to the application. For now I've applied a temporary fix for our go version detection, but in pixie-io#1300 and pixie-io#1318 we need to revamp how this detection works since it has issues with 32 bit binaries and now binaries built for go 1.20.4 and later. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Existing tests should provide enough coverage. - [x] Verified that `go_tls_trace_bpf_tests` failing on pixie-io#1266 pass ([P381](https://phab.corp.pixielabs.ai/P381)) --------- Signed-off-by: Vihang Mehta <vihang@pixielabs.ai> Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai> Co-authored-by: Vihang Mehta <vihang@pixielabs.ai>
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
…lures (pixie-io#1319) Summary: This upgrades our golang SDKs to the latest patch version to pull in bug fixes and security fixes. Our go tls tracing tests failed with this minor version upgrade. These failures are due to our go version detection failing, which prevents stirling from adding uprobes to the application. For now I've applied a temporary fix for our go version detection, but in pixie-io#1300 and pixie-io#1318 we need to revamp how this detection works since it has issues with 32 bit binaries and now binaries built for go 1.20.4 and later. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Existing tests should provide enough coverage. - [x] Verified that `go_tls_trace_bpf_tests` failing on pixie-io#1266 pass ([P381](https://phab.corp.pixielabs.ai/P381)) --------- Signed-off-by: Vihang Mehta <vihang@pixielabs.ai> Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai> Co-authored-by: Vihang Mehta <vihang@pixielabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This upgrades our golang SDKs to the latest patch version
to pull in bug fixes and security fixes.
Our go tls tracing tests failed with this minor version upgrade. These failures are due to our go version detection failing, which prevents stirling from adding uprobes to the application. For now I've applied a temporary fix for our go version detection, but in #1300 and #1318 we need to revamp how this detection works since it has issues with 32 bit binaries and now binaries built for go 1.20.4 and later.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Existing tests should provide enough coverage.
go_tls_trace_bpf_testsfailing on Upgrade golang #1266 pass (P381)